I'd have to say my favorite module as a player was
B1, as run online by Badmike last year. It was my first AD&D game in over 20 years and a hell of a lot of fun.
Still waiting for Mike to pick up that campaign again...

:nudge: :nudge:
As a
DM, my favorites are
T1-4 (which I am running now!),
Dragon Mountain (got to love those kobolds), and
Ravenloft I and
II: The House on Gryphon Hill. While many people hated I10 because of the helter-skelter writing and plot, I found that if you ran Ravenloft and Ravenloft II together, as suggested, it was pretty amazing. Kept the players guessing constantly, and none could figure out which module was reality and which was the dream!